Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beacon event types from MSC3489 #2230

Merged
merged 16 commits into from
Mar 14, 2022
Merged

Beacon event types from MSC3489 #2230

merged 16 commits into from
Mar 14, 2022

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Mar 10, 2022

Spec: matrix-org/matrix-spec-proposals#3489

Adds types and content helper functions for m.beacon_info and m.beacon events.


Here's what your changelog entry will look like:

✨ Features

Kerry Archibald added 7 commits March 10, 2022 11:08
Signed-off-by: Kerry Archibald <kerrya@element.io>
.ts");

Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #2230 (9367c6f) into develop (9058dbf) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2230      +/-   ##
===========================================
+ Coverage    57.82%   57.84%   +0.02%     
===========================================
  Files           90       91       +1     
  Lines        16300    16308       +8     
  Branches      3756     3757       +1     
===========================================
+ Hits          9425     9433       +8     
  Misses        6875     6875              
Impacted Files Coverage Δ
src/@types/beacon.ts 100.00% <100.00%> (ø)
src/content-helpers.ts 75.00% <100.00%> (+3.57%) ⬆️

Kerry Archibald added 2 commits March 10, 2022 18:19
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
@kerryarchibald kerryarchibald force-pushed the psf-772/beacon-events branch from 536ed45 to e1b6ceb Compare March 10, 2022 17:21
Kerry Archibald added 5 commits March 11, 2022 09:56
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
@kerryarchibald kerryarchibald marked this pull request as ready for review March 11, 2022 09:47
@kerryarchibald kerryarchibald requested a review from a team as a code owner March 11, 2022 09:47
Signed-off-by: Kerry Archibald <kerrya@element.io>
@kerryarchibald kerryarchibald marked this pull request as draft March 11, 2022 12:46
@kerryarchibald kerryarchibald marked this pull request as ready for review March 11, 2022 14:11
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kerryarchibald
Copy link
Contributor Author

Returning to draft while matrix-org/matrix-spec-proposals#3672 is so active

@kerryarchibald kerryarchibald marked this pull request as draft March 11, 2022 16:03
@kerryarchibald kerryarchibald marked this pull request as ready for review March 14, 2022 12:11
@kerryarchibald kerryarchibald enabled auto-merge (squash) March 14, 2022 12:11
@kerryarchibald kerryarchibald merged commit d064d82 into develop Mar 14, 2022
@kerryarchibald kerryarchibald deleted the psf-772/beacon-events branch March 14, 2022 12:13
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Apr 1, 2022
* emit aggregate room beacon liveness ([\matrix-org#2241](matrix-org#2241)).
* Live location sharing - create m.beacon_info events ([\matrix-org#2238](matrix-org#2238)).
* Beacon event types from MSC3489 ([\matrix-org#2230](matrix-org#2230)).
* Fix incorrect usage of unstable variant of `is_falling_back` ([\matrix-org#2227](matrix-org#2227)).
wx870601 added a commit to eachchat/matrix-js-sdk that referenced this pull request Apr 6, 2022
* emit aggregate room beacon liveness ([\matrix-org#2241](matrix-org#2241)).
* Live location sharing - create m.beacon_info events ([\matrix-org#2238](matrix-org#2238)).
* Beacon event types from MSC3489 ([\matrix-org#2230](matrix-org#2230)).
* Fix incorrect usage of unstable variant of `is_falling_back` ([\matrix-org#2227](matrix-org#2227)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants